Skip to content

refactor(icon): change deprecated APIs for version 10 #19323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

refactor(icon): change deprecated APIs for version 10 #19323

merged 1 commit into from
May 26, 2020

Conversation

crisbeto
Copy link
Member

Changes the APIs that were marked as deprecated for v10.

BREAKING CHANGES:

  • The _location and _errorHandler parameters in the MatIcon constructor are now required.
  • The _errorHandler parameter in the MatIconRegistry constructor is now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 11, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 11, 2020
@crisbeto crisbeto requested review from devversion, jelbourn and a team as code owners May 11, 2020 20:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 11, 2020
@crisbeto crisbeto force-pushed the icon-v10-breaking-changes branch from 4469786 to 7c74f6f Compare May 11, 2020 20:05
jelbourn
jelbourn approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 12, 2020
@crisbeto crisbeto force-pushed the icon-v10-breaking-changes branch from 7c74f6f to 834c192 Compare May 15, 2020 17:24
jelbourn
jelbourn approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto force-pushed the icon-v10-breaking-changes branch from 834c192 to d3d7b0d Compare May 23, 2020 10:06
@crisbeto
refactor(icon): change deprecated APIs for version 10
d8ef05e 
Changes the APIs that were marked as deprecated for v10.

BREAKING CHANGES:
* The `_location` and `_errorHandler` parameters in the `MatIcon` constructor are now required.
* The `_errorHandler` parameter in the `MatIconRegistry` constructor is now required.
@crisbeto crisbeto force-pushed the icon-v10-breaking-changes branch from d3d7b0d to d8ef05e Compare May 26, 2020 17:31
@jelbourn jelbourn merged commit dd73e36 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot